Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not set color on elements which cannot have it #1735

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Do not set color on elements which cannot have it #1735

merged 1 commit into from
Sep 2, 2022

Conversation

barmac
Copy link
Member

@barmac barmac commented Sep 2, 2022

Closes #1734

@barmac barmac requested review from a team, philippfromme and pinussilvestrus and removed request for a team September 2, 2022 14:28
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 2, 2022
@barmac barmac changed the base branch from develop to master September 2, 2022 14:29
@fake-join fake-join bot merged commit a994bdc into master Sep 2, 2022
@fake-join fake-join bot deleted the 1734-fix-color branch September 2, 2022 15:19
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 2, 2022
@smbea smbea mentioned this pull request Sep 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

@philippfromme philippfromme Awaiting requested review from philippfromme philippfromme was automatically assigned from bpmn-io/modeling-dev

@pinussilvestrus pinussilvestrus Awaiting requested review from pinussilvestrus pinussilvestrus was automatically assigned from bpmn-io/modeling-dev

Assignees

@barmac barmac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

modeling#setColor sets color on BPMNPlane
2 participants
@barmac @nikku