Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update google-github-actions/release-please-action action to v4 #2041

Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 1, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
google-github-actions/release-please-action action major v3 -> v4

Release Notes

google-github-actions/release-please-action (google-github-actions/release-please-action)

v4

Compare Source


Configuration

📅 Schedule: Branch creation - "after 10pm,before 5:00am" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Updates a dependency label Dec 1, 2023
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Dec 1, 2023
@nikku
Copy link
Member

nikku commented Dec 4, 2023

This is a breaking change that we want to assess carefully.

@barmac barmac self-requested a review December 4, 2023 14:15
@barmac
Copy link
Member

barmac commented Dec 4, 2023

I am looking into this.

Copy link
Contributor Author

renovate bot commented Dec 4, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@barmac
Copy link
Member

barmac commented Dec 4, 2023

I updated the configuration according to https://github.com/google-github-actions/release-please-action#upgrading-from-v3-to-v4
This should work fine.

@barmac barmac merged commit 5d8d0a2 into develop Dec 4, 2023
@barmac barmac deleted the renovate/google-github-actions-release-please-action-4.x branch December 4, 2023 14:25
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 4, 2023
@barmac
Copy link
Member

barmac commented Dec 4, 2023

Looks like I messed this up: https://github.com/bpmn-io/bpmn-js/actions/runs/7087995141

@barmac
Copy link
Member

barmac commented Dec 4, 2023

If you were previously configuring advanced options via GitHub action inputs, you will need to configure via the release-please manifest configuration instead.

Oh OK

@barmac
Copy link
Member

barmac commented Dec 5, 2023

Fixed via 0b4e7a3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Updates a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants