feat(popup-menu): allow additional search terms

Related to bpmn-io/bpmn-js#1816
bpmn-io · Jan 25, 2023 · 6125c80 · 6125c80
1 parent 8966c4e
commit 6125c80
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 2 deletions.
diff --git a/lib/features/popup-menu/PopupMenuComponent.js b/lib/features/popup-menu/PopupMenuComponent.js
@@ -93,7 +93,8 @@ export default function PopupMenuComponent(props) {
 
       const search = [
         entry.description || '',
-        entry.label || ''
+        entry.label || '',
+        entry.search || ''
       ]
         .join('---')
         .toLowerCase();

diff --git a/test/spec/features/popup-menu/PopupMenuComponentSpec.js b/test/spec/features/popup-menu/PopupMenuComponentSpec.js
@@ -439,7 +439,7 @@ describe('features/popup-menu - <PopupMenu>', function() {
       { id: '2', label: 'Entry 2' },
       { id: '3', label: 'Entry 3' },
       { id: '4', label: 'Entry 4' },
-      { id: '5', label: 'Entry 5' },
+      { id: '5', label: 'Entry 5', search: 'foo' },
       { id: 'some_entry_id', label: 'Last' }
     ];
 
@@ -525,6 +525,26 @@ describe('features/popup-menu - <PopupMenu>', function() {
     });
 
 
+    it('should search additional "search" terms', async function() {
+
+      // given
+      createPopupMenu({ container, entries, search: true });
+
+      var searchInput = domQuery('.djs-popup-search input', container);
+      searchInput.value = entries[4].search;
+
+      // when
+      searchInput.dispatchEvent(keyDown('ArrowUp'));
+      searchInput.dispatchEvent(keyUp('ArrowUp'));
+
+      await whenStable();
+
+      // then
+      expect(domQueryAll('.entry', container)).to.have.length(1);
+      expect(domQuery('.entry .djs-popup-label', container).textContent).to.eql('Entry 5');
+    });
+
+
     it('should not search id', async function() {
 
       // given