Skip to content

Commit

Permalink
chore(modeling): remove <connection.reconnectStart/End> command
Browse files Browse the repository at this point in the history
BREAKING CHANGES:

* <connection.reconnectStart/End> commands removed
* Modeling#reconnectStart/End still available for convenience
  • Loading branch information
philippfromme committed Nov 14, 2019
1 parent 156f90f commit e96165b
Showing 1 changed file with 13 additions and 17 deletions.
30 changes: 13 additions & 17 deletions lib/features/modeling/Modeling.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import {
assign,
forEach,
isArray
} from 'min-dash';
Expand Down Expand Up @@ -75,9 +76,6 @@ Modeling.prototype.getHandlers = function() {

'connection.updateWaypoints': UpdateWaypointsHandler,

'connection.reconnectStart': ReconnectConnectionHandler,
'connection.reconnectEnd': ReconnectConnectionHandler,

'connection.reconnect': ReconnectConnectionHandler,

'elements.create': CreateElementsHandler,
Expand Down Expand Up @@ -481,25 +479,23 @@ Modeling.prototype.reconnect = function(connection, source, target, dockingOrPoi
};

Modeling.prototype.reconnectStart = function(connection, newSource, dockingOrPoints, hints) {
var context = {
connection: connection,
newSource: newSource,
dockingOrPoints: dockingOrPoints,
hints: hints || {}
};
if (!hints) {
hints = {};
}

this._commandStack.execute('connection.reconnectStart', context);
this.reconnect(connection, newSource, connection.target, dockingOrPoints, assign(hints, {
docking: 'source'
}));
};

Modeling.prototype.reconnectEnd = function(connection, newTarget, dockingOrPoints, hints) {
var context = {
connection: connection,
newTarget: newTarget,
dockingOrPoints: dockingOrPoints,
hints: hints || {}
};
if (!hints) {
hints = {};
}

this._commandStack.execute('connection.reconnectEnd', context);
this.reconnect(connection, connection.source, newTarget, dockingOrPoints, assign(hints, {
docking: 'target'
}));
};

Modeling.prototype.connect = function(source, target, attrs, hints) {
Expand Down

0 comments on commit e96165b

Please sign in to comment.