Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bottom padding not taken into account #259

Closed
philippfromme opened this issue Jun 12, 2018 · 0 comments
Closed

Bottom padding not taken into account #259

philippfromme opened this issue Jun 12, 2018 · 0 comments
Assignees
@nikku
Labels
bug Something isn't working

Comments

@philippfromme
Copy link
Contributor

When layouting text bottom padding is parsed but not taken into account when calculating height of layouted text.
@philippfromme philippfromme added the bug Something isn't working label Jun 12, 2018
philippfromme added a commit that referenced this issue Jun 12, 2018
@philippfromme
fix(text): take bottom padding into account
7752b1e 
Fixes #259
@ghost ghost assigned philippfromme Jun 12, 2018
@ghost ghost added the in progress Currently worked on label Jun 12, 2018
philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue Jun 13, 2018
@philippfromme
fix(label-behavior): text annotation resizing after text property change
f36aea8 
Depends on bpmn-io/diagram-js#259

Related to camunda/camunda-modeler#631
@philippfromme philippfromme mentioned this issue Jun 13, 2018
Closed
@philippfromme philippfromme added needs review Review pending and removed in progress Currently worked on labels Jun 13, 2018
@philippfromme philippfromme assigned nikku and unassigned philippfromme Jun 13, 2018
@nikku nikku closed this as completed in d64f131 Jun 13, 2018
@ghost ghost removed the needs review Review pending label Jun 13, 2018
nikku pushed a commit to bpmn-io/bpmn-js that referenced this issue Jun 13, 2018
@philippfromme @nikku
fix(label-behavior): text annotation resizing after text property change
100f3fb 
Depends on bpmn-io/diagram-js#259

Related to camunda/camunda-modeler#631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nikku @philippfromme