Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click on popup menu closes it #702

Closed
Tracked by #1793
smbea opened this issue Nov 21, 2022 · 0 comments · Fixed by #705
Closed
Tracked by #1793

Click on popup menu closes it #702

smbea opened this issue Nov 21, 2022 · 0 comments · Fixed by #705
Assignees
@nikku
Labels
bug Something isn't working

Comments

@smbea
Copy link
Contributor

smbea commented Nov 21, 2022 •
edited
Loading

Describe the Bug

Clicking on the popup menu causes the menu to close

Steps to Reproduce

Screen.Recording.2022-11-21.at.09.58.51.mov

Steps to reproduce the behavior:

  1. open popup menu
  2. click on menu or search bar
  3. see that pop up menu closes

Expected Behavior

Popup menu shouldn't close with click inside menu

Environment

Please complete the following information:

  • Library version: 11.0.0
@smbea smbea added the bug Something isn't working label Nov 21, 2022
@smbea smbea mentioned this issue Nov 21, 2022
Merged
@smbea smbea added the ready Ready to be worked on label Nov 21, 2022
@smbea smbea mentioned this issue Nov 21, 2022
Closed
19 tasks
nikku added a commit that referenced this issue Nov 21, 2022
@nikku
fix: do not close popup menu on click
47bcb1c 
This makes popup closing an integrators responsibility (again).

Reverting back to the more predictable diagram-js@10 behavior.

Closes #702
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Nov 21, 2022
@nikku nikku mentioned this issue Nov 21, 2022
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 21, 2022
nikku added a commit that referenced this issue Nov 21, 2022
@nikku
fix(popup-menu): do not close on click
e218700 
This makes popup closing an integrators responsibility (again).

Reverting back to the more predictable diagram-js@10 behavior.

Closes #702
barmac pushed a commit that referenced this issue Nov 22, 2022
@nikku @barmac
fix(popup-menu): do not close on click
ce9ea8f 
This makes popup closing an integrators responsibility (again).

Reverting back to the more predictable diagram-js@10 behavior.

Closes #702
barmac pushed a commit that referenced this issue Nov 22, 2022
@nikku @barmac
fix(popup-menu): do not close on click
09d793c 
This makes popup closing an integrators responsibility (again).

Reverting back to the more predictable diagram-js@10 behavior.

Closes #702
barmac pushed a commit that referenced this issue Nov 22, 2022
@nikku @barmac
fix(popup-menu): do not close on click
ada4299 
This makes popup closing an integrators responsibility (again).

Reverting back to the more predictable diagram-js@10 behavior.

Closes #702
barmac pushed a commit that referenced this issue Nov 22, 2022
@nikku @barmac
fix(popup-menu): do not close on click
fda29e8 
This makes popup closing an integrators responsibility (again).

Reverting back to the more predictable diagram-js@10 behavior.

Closes #702
barmac pushed a commit that referenced this issue Nov 22, 2022
@nikku @barmac
fix(popup-menu): do not close on click
898e821 
This makes popup closing an integrators responsibility (again).

Reverting back to the more predictable diagram-js@10 behavior.

Closes #702
barmac pushed a commit that referenced this issue Nov 22, 2022
@nikku @barmac
fix(popup-menu): do not close on click
5f42235 
This makes popup closing an integrators responsibility (again).

Reverting back to the more predictable diagram-js@10 behavior.

Closes #702
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 22, 2022
@smbea smbea mentioned this issue Nov 22, 2022
Closed
4 tasks
@smbea smbea mentioned this issue Dec 13, 2022
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not close popup on click bpmn-io/diagram-js
2 participants
@nikku @smbea