You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the connect tool should now be enabled/disabled rapidly
click on an element
The error is shown in the console
Root Cause:
This behavior causes a mismatch between Dragging state Active state in the tool manager. When we try to start a connection through clicking, dragging is initiated. Because we cancel the event (
) while we are initiating the drag operation, it breaks when we access the context immediately after.
Proposed Fix:
It is not clear why we cancel dragging in this place. This should be handled either by dragging or a higher component, such as global-connect. This is already the case.
No tests break in diagram-js and bpmn-js by just removing this logic, and with my tests, everything still works as expected.
The text was updated successfully, but these errors were encountered:
See comment, wrong issue linked initially
Steps to Reproduce:
c
in the editorRoot Cause:
This behavior causes a mismatch between Dragging state Active state in the tool manager. When we try to start a connection through clicking, dragging is initiated. Because we cancel the event (
diagram-js/lib/features/tool-manager/ToolManager.js
Lines 87 to 88 in 0ec9a13
Proposed Fix:
It is not clear why we cancel dragging in this place. This should be handled either by
dragging
or a higher component, such asglobal-connect
. This is already the case.No tests break in diagram-js and bpmn-js by just removing this logic, and with my tests, everything still works as expected.
The text was updated successfully, but these errors were encountered: