Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragging preview does not show Connection markers #904

Closed
marstamm opened this issue May 24, 2024 · 1 comment · Fixed by #906
Closed

Dragging preview does not show Connection markers #904

marstamm opened this issue May 24, 2024 · 1 comment · Fixed by #906
Assignees
@marstamm
Labels
bug Something isn't working spring cleaning Could be cleaned up one day

Comments

@marstamm
Copy link
Contributor

Describe the Bug

When I drag elements to rearange them, the end marker is not shown

image

Steps to Reproduce

  1. Open https://demo.bpmn.io/s/start
  2. Select all
  3. Drag around the canvas
  4. The preview does not have arrow heads

Expected Behavior

Similar to pasting, connection end markers should be shown:
image

Environment

Please complete the following information:

  • Browser: Chrome
  • OS: -
  • Library version: dev

Notes

This happens because drag.cleanup is called immediately on start, which cleans up clones markers.

Found during and related to camunda/camunda-modeler#4307
@marstamm marstamm added bug Something isn't working spring cleaning Could be cleaned up one day labels May 24, 2024
@marstamm marstamm self-assigned this May 24, 2024
marstamm added a commit that referenced this issue May 27, 2024
@marstamm
feat(preview-support): add copied marker as part of visual
d193d08 
closes #904
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label May 27, 2024
marstamm added a commit that referenced this issue May 27, 2024
@marstamm
feat(preview-support): add copied marker as part of visual
4f9f0bd 
closes #904
marstamm added a commit that referenced this issue May 27, 2024
@marstamm
feat(preview-support): add copied marker as part of visual
1161275 
closes #904
@marstamm marstamm mentioned this issue May 27, 2024
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels May 27, 2024
marstamm added a commit that referenced this issue May 28, 2024
@marstamm
feat(preview-support): add copied marker as part of visual
639af8c 
closes #904
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 28, 2024
@nikku
Copy link
Member

nikku commented May 28, 2024

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marstamm marstamm

Labels
bug Something isn't working spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(preview-support): add copied marker as part of djs-visual bpmn-io/diagram-js
2 participants
@nikku @marstamm