Allow element hit boxes to be customized #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
requested changes
Jun 20, 2019
nikku
force-pushed
the
238-participant-navigation
branch
from
ae5b8af to
c15d994
Compare
This comment has been minimized.
This comment has been minimized.
barmac
force-pushed
the
238-participant-navigation
branch
from
c15d994 to
3df63b8
Compare
nikku
force-pushed
the
238-participant-navigation
branch
from
3df63b8 to
e032eda
Compare
This allows users to take fine-grained control over element hit boxes:
* provide APIs for creating and clearing hit boxes
* support three different types of hit-boxes and user interactions:
- all: react to all pointer events
- stroke: react to stroke pointer events
- click-stroke: <stroke> when click interacting, <all> otherwise
* hooking into the `interactionEvents.createHit` and
`interactionEvents.updateHit` events to take over hit box creation
nikku
force-pushed
the
238-participant-navigation
branch
from
e032eda to
53c59c9
Compare
|
I've updated this PR as discussed and provided the ability to create custom hit shapes from within diagram-js. Checkout bpmn-io/bpmn-js@63994d1 for actual usage / impact of this change. @barmac Could you have a look? I'm happy to approve this PR once I get your O.K. 🇧🇶 |
nikku
changed the title
|
Thanks @philippfromme for OK 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to take fine-grained control over element hit boxes:
interactionEvents.createHitandinteractionEvents.updateHitevents to take over hit box creation