Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Auto-Place Feature #443

Merged
merged 2 commits into from
Mar 4, 2020
Merged

Add Auto-Place Feature #443

merged 2 commits into from
Mar 4, 2020

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Mar 2, 2020 •
edited
Loading

  • allow connecting from new shape to source on append
  • add auto-place feature

Required by bpmn-io/bpmn-js#1284
Required by bpmn-io/dmn-js#481

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Mar 2, 2020
@philippfromme philippfromme mentioned this pull request Mar 2, 2020
Merged
@philippfromme philippfromme changed the title Top-Down Modeling Add Auto-Place Feature Mar 2, 2020
@philippfromme philippfromme mentioned this pull request Mar 2, 2020
Closed
@philippfromme philippfromme requested a review from nikku March 3, 2020 10:42
nikku
nikku requested changes Mar 3, 2020
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, please do the following:

  • Move the default placement outside the utility
  • Test the exposed utility functions, as it is API surface, effectively

@philippfromme philippfromme force-pushed the 470-top-down-modeling branch from e85f9e7 to 5b77fad Compare March 4, 2020 14:14
@philippfromme philippfromme force-pushed the 470-top-down-modeling branch from 5b77fad to f5beec9 Compare March 4, 2020 14:20
@nikku nikku self-requested a review March 4, 2020 14:22
@fake-join fake-join bot merged commit 7943488 into develop Mar 4, 2020
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 4, 2020
@fake-join fake-join bot deleted the 470-top-down-modeling branch March 4, 2020 14:25
@philippfromme philippfromme mentioned this pull request Apr 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippfromme @nikku