Adding charCode compare(multilanguage support)

[Quieska]

Added charCode compare(multilanguage support)
The proplem it fixed is hotkeys (ctrl+z, ctrl+c ... etc.) not working in other locales.
Now hotkeys working in all languales (Russian, Serbian... etc.) :)

[CLAassistant]

All committers have signed the CLA.

[nikku]

Thanks for your PR!

Could you elaborate on what you do and why?

If you contribute fixes, please also consider adding accompanying test cases.

[Quieska]

keys.indexOf(event.key) > -1
keys is an array [z, Z].
event.key in English locale is "z" for example, but in my another locale it is "я"
It's not working with finding String.
It can be fixing by taking event.keyCode, transform to String and search it in keys array

[Quieska]

Thanks for your PR!

Could you elaborate on what you do and why?

If you contribute fixes, please also consider adding accompanying test cases.

Hello! Thanks for your reply!
I made some test cases. You can remove comparing by keyCode and see that new test cases failing :)

[nikku]

To better understand your case you'd still press CTRL + я on your keyboard as a UNDO shortcut?

[Quieska]

To better understand your case you'd still press CTRL + я on your keyboard as a UNDO shortcut?

Yes, all shortcuts works like earlier, but not only in english locale

[nikku]

This is an interesting detail, indeed.

Looking at my german keyboard (where Z and Y are swapped): Given your solution, pressing the English keyboard shortcut would yield CTRL + Z even though it says CTRL + Y and I'd expect it to REDO.

Guess we'll need to investigate this issue a little further.

[Quieska]

This is an interesting detail, indeed.

Looking at my german keyboard (where Z and Y are swapped): Given your solution, pressing the English keyboard shortcut would yield CTRL + Z even though it says CTRL + Y and I'd expect it to REDO.

Guess we'll need to investigate this issue a little further.

So look on it not like CTRL+Z(on english) or CTRL+Y(on german) or CTRL+Я(on russian)
It CTRL+KeyCode = 90 for UNDO for all locales. That what i did.

[philippfromme]

Actually, undoing on a German keyboard is CTRL + Z, the physical key is just somewhere else on the keyboard.

[philippfromme]

So the issue is that key is referring to the character that's generated whereas both keyCode and the more recent key refer to the physical key on the keyboard. Since we're only using key right now the shortcuts are working on QWERTY-based Latin-script keyboard layouts but not on others. We should use both key and as a fallback keyCode to ensure the shortcuts are working properly on all keyboards.

[philippfromme]

We shouldn't use charCode as it's both non-standard and deprecated.

[philippfromme]

Hey @Quieska,

since I have not received a response from you I took over this PR and finished it. Thank you for bringing up this topic. In future releases, the shortcuts will work across all keyboards.

Closed via #460.

[Quieska]

Hello @philippfromme!
Nice to hear it. I saw your PR and think it will work fine, especially you tested it on russian keyboard) Thanks for fast work! Me and my company waiting for future release.