Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle stopPropagation for iphone and ipad devices #492

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

oguzeroglu
Copy link
Contributor

@oguzeroglu oguzeroglu commented Oct 5, 2020

Fixes touch bugs that occur frequently in Sentry (https://sentry.io/organizations/camunda-modeling/issues/1640119817/?project=5218065&query=is%3Aunresolved&statsPeriod=24h)

For the solution, see: https://stackoverflow.com/questions/26027362/how-to-stoppropagation-w-hammer-js-2-0

I tested this with my iPhone and can confirm it works. One can also test this with XCode iPhone simulator & remote debugging via Safari on MacOS devices.

Definition of Done

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Oct 5, 2020
@oguzeroglu oguzeroglu changed the title Correctly handle stopPropogation for iphone and ipad devices Correctly handle stopPropagation for iphone and ipad devices Oct 5, 2020
@oguzeroglu oguzeroglu requested review from nikku and barmac October 5, 2020 13:11
Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works correctly on iPhone simulator.

@nikku
Copy link
Member

nikku commented Oct 5, 2020

Let us merge and ship it then and see if it fixes things in real life, too.

@nikku nikku merged commit 0fbbbd1 into master Oct 5, 2020
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 5, 2020
@fake-join fake-join bot deleted the iphone-touch-stoppropagation-fix branch October 5, 2020 13:30
@MaxTru MaxTru added this to the M42 milestone Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants