fix(keyboard): bind zoom in to = key

[barmac]

This is required for the feature to work on international
keyboard layout.

Related to bpmn-io/bpmn-js#1362

Acceptance Criteria

• Corresponds to the concept
• Corresponds to the design

Definition of Done

• corresponds to the design principles
• corresponds to the code standards
• passes Continuous Integration checks
• available as feature branch on GitHub
  • contains the cleaned up commit history
  • commit messages satisfy our commit message guidelines
  • a single commit closes the issue via Closes #issuenr

[barmac]

@pinussilvestrus @nikku Can you please review this?

[pinussilvestrus]

For my understanding (also cf. the discussion starting here: bpmn-io/bpmn-js#1362 (comment)):

This fix shouldn't cause that CMD+= triggers the zoom on German keyboards as well, right? Since this resolves to key 0.

That's at least what I'd expect and it looks like it's working. Don't have an international keyboard, so I can only verify it does not break the existing behavior on German keyboard.

[nikku]

This fix shouldn't cause that CMD+= triggers the zoom on German keyboards as well, right? Since this resolves to key 0.

Good point and makes me more confident in the solution suggested. I'll double check the behavior on Linux. Maybe we can give this a quick 👍 and merge.

[barmac]

To sum up the concerns, this change could be a problem only in a keyboard layout where you can type = but it's not coupled with + on the same keyboard key. Only in that situation you could be surprised with the result of Cmd + [=]. I checked also AZERTY layout and it's not the case there.

[pinussilvestrus]

To sum up the concerns, this change could be a problem only in a keyboard layout where you can type = but it's not coupled with + on the same keyboard key. Only in that situation you could be surprised with the result of Cmd + [=]. I checked also AZERTY layout and it's not the case there.

So far I can't think about or even know a keyboard layout where this is the case. I think it's okay to merge this one (if it's working on all platforms) and wait for a response in case this breaks on any keyboard.

[barmac]

I looked through Wikipedia and found some layouts I haven't heard of which could potentially run into this issue: JCUKEN (Latin), BÉPO and Blickensderfer. Still, for them it's just a second shortcut, but the first one for international (and Polish as well) layout users.

[nikku]

Did not see any side-effects on Linux.

Cannot reproduce the CTRL/CMD behavior (bpmn-io/bpmn-js#1362 (comment)), too. So that one seems to be a MacOS specific thing.