feat(canvas): allow creating planes from descriptors #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marstamm
added
in progress
|
As discussed, we will change the API like this:
Potentially Breaking Changes
Other potential improvements |
- add rootElement on createPlane - remove rootElement on removePlane, but keep rootElement as part of planeDescriptor
marstamm
force-pushed
the
create-planes-from-descriptor
branch
from
db76a1e to
f4aa05b
Compare
|
Ready for review. I only adjusted with non-breaking changes and kept the general API for now. An example of how it is used is implemented here: https://github.com/bpmn-io/bpmn-js/pull/1538/files#diff-72a5e1f4e48dd45f7e30a07fb4234e5978d62f9ac15fb2d716b1348d0503e758R37-R58 |
marstamm
added
needs review
nikku
approved these changes
Dec 8, 2021
| children: [], | ||
| isImplicit: true | ||
| }; | ||
| } | ||
|
|
||
| var svgLayer = this.getLayer(name, PLANE_LAYER_INDEX); | ||
| svgAttr(svgLayer, 'display', 'none'); | ||
| this._addRoot(plane.rootElement, plane); |
There was a problem hiding this comment.
I like this very much, as if we're already transitioning to #600. 😉 ❤️
| } | ||
|
|
||
| if (typeof plane === 'string') { | ||
| plane = { name: plane }; |
There was a problem hiding this comment.
Could simplify this to:
if (typeof plane === 'string') {
plane = { name: plane, rootElement: rootElement };
}
| rootElement = { | ||
| id: '__implicitroot' + name, | ||
| if (!plane.rootElement) { | ||
| plane.rootElement = rootElement || { |
There was a problem hiding this comment.
Could simplfy this to:
plane.rootElement = { ... }
If we do ⬆️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #598