Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(palette): correct separator spacing #633

Merged
merged 1 commit into from
Mar 28, 2022
Merged

fix(palette): correct separator spacing #633

merged 1 commit into from
Mar 28, 2022

Conversation

nikku
Copy link
Member

@nikku nikku commented Mar 27, 2022 •
edited
Loading

This corrects the spacing of the palette separator:

capture kQmTbX_optimized

Here is an example with a complex palette (mix of icon font (:before) + image entries:

capture z0XWCC_optimized

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Mar 27, 2022
@nikku nikku force-pushed the correct-separator-alignment branch from f697584 to ff56c7c Compare March 27, 2022 15:52
@nikku nikku changed the base branch from develop to master March 27, 2022 16:58
@nikku nikku force-pushed the correct-separator-alignment branch from ff56c7c to 988cb69 Compare March 27, 2022 16:58
@nikku
Copy link
Member Author

nikku commented Mar 27, 2022 •
edited
Loading

Applications (Camunda Web Modeler, for example) and libraries (i.e. connectors modeling demo) need to otherwise work around this.

@nikku nikku requested review from a team, Skaiir and barmac and removed request for a team March 28, 2022 07:25
barmac
barmac approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Looks OK if the extension creators use some transparent padding in their icons.

@fake-join fake-join bot merged commit 16370ce into master Mar 28, 2022
@fake-join fake-join bot deleted the correct-separator-alignment branch March 28, 2022 07:39
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac approved these changes

@Skaiir Skaiir Awaiting requested review from Skaiir Skaiir was automatically assigned from bpmn-io/modeling-dev

Assignees

@nikku nikku

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikku @barmac