Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: comply with style-src CSP #636

Merged
merged 1 commit into from
May 16, 2022
Merged

fix: comply with style-src CSP #636

merged 1 commit into from
May 16, 2022

Conversation

marstamm
Copy link
Contributor

@marstamm marstamm commented May 16, 2022

This PR removes all inline styles and replaces them with direct assignment to Comply with CSP style-src.

Related to bpmn-io/bpmn-js#1625

@marstamm marstamm self-assigned this May 16, 2022
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label May 16, 2022
@marstamm marstamm marked this pull request as ready for review May 16, 2022 14:08
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels May 16, 2022
@marstamm marstamm requested review from a team, pinussilvestrus and smbea and removed request for a team May 16, 2022 14:08
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very nice.

@pinussilvestrus pinussilvestrus changed the title WIP: fix: comply with style-src CSP fix: comply with style-src CSP May 16, 2022
@fake-join fake-join bot merged commit 857b407 into master May 16, 2022
@fake-join fake-join bot deleted the style-src-CSP branch May 16, 2022 14:16
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants