-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add move cursor #643
Add move cursor #643
Conversation
To consider: Movement is not the only action available in such situation. I can also click to select the shape which is not the action indicated by the cursor. Also, over a task, the double-click allows to change the label name which is totally different from what the cursor shows. I think it's interesting that the proposed solution is in line with what Excalidraw offers but different than Miro's experience (where it's as is in bpmn-js now). |
I believe this solution makes sense if we stick to the decision to remove the hover outline. |
Agreed. It is also similar to GSlides + a bunch of other drawing tools that I investigated; hence I proposed it. |
@barmac Could you share a screencapture how it looks like for you (during hovering and dragging)? We have to make sure our overall cursor-interaction works and my OS is very minimal in this case (just a few cursors to choose). |
Sure, I will do that shortly. |
Screen.Recording.2022-05-20.at.11.43.21.mov |
It looks the same in Safari, so the cursor is probably browser-independent. |
Yes, it is OS-dependent. |
Looks worse on Mac than it does on Linux I gotta say. |
Alternative is to use |
It clashes a little with the sequence flow elbows when you come near the connection drag handle: Bildschirmaufnahme.2022-05-20.um.12.00.08.movIt is then not clear if you create a new elbow or pick the connection drag handle. I would also suggest not use @barmac s point is valid, but until today no one came up with a solution for a cursor that indicates the double click function (secondary action)... and we can not simply show a |
Let's allow @andreasgeier to chime in and then we can pragmatically decide whether we want this (or not). |
21e4c8f
to
c5b1706
Compare
This builds on top of #640 and adds a move cursor as known from other well known drawing tools.
The cursor visually indicates to me whether I'm hovering over an active drag region:
Can be tried out via