Group popup menu items #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to style specific popup menu.
barmac
force-pushed
the
group-popup-menu-items
branch
from
a9dd9ce to
b77acf5
Compare
barmac
requested review from
a team,
Skaiir,
marstamm,
philippfromme,
pinussilvestrus and
smbea
and removed request for
a team,
marstamm,
Skaiir and
pinussilvestrus
nikku
requested changes
Jun 27, 2022
lib/features/popup-menu/PopupMenu.js
Outdated
| groupContainer = domQuery('[data-group=' + grouping + ']', entriesContainer); | ||
|
|
||
| if (!groupContainer) { | ||
| groupContainer = domify('<div class="group" data-group="' + grouping + '"></div>'); |
There was a problem hiding this comment.
We should escape grouping to not allow XSS.
There was a problem hiding this comment.
Valid point. We will need to fix it in the context pad as well.
There was a problem hiding this comment.
This is now fixed, but there are also a couple of other places where we allow DOM injection. I will fix them.
bpmn-io-tasks
bot
added
in progress
barmac
force-pushed
the
group-popup-menu-items
branch
from
171f419 to
ec76fdd
Compare
|
I fixed the existing XSS vulnerabilities via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for bpmn-io/bpmn-js#1682