Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(keyboard): make function detection available via explicit utilities #664

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

nikku
Copy link
Member

@nikku nikku commented Aug 16, 2022

Backports #665 to 8.x.

* expose dedicated utils for function detection via `KeyboardUtil`:
   * isCopy
   * isPaste
   * isUndo
   * isRedo
@nikku nikku requested a review from philippfromme August 16, 2022 22:29
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Aug 16, 2022
@nikku nikku requested review from a team and smbea and removed request for a team August 17, 2022 08:08
Copy link
Contributor

@smbea smbea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very readable 🙌 Looks good

@fake-join fake-join bot merged commit 221eed4 into 8.x Aug 17, 2022
@fake-join fake-join bot deleted the undo-redo-util-8.x branch August 17, 2022 10:19
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants