Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: provide diagram-js/lib/ui #692

Merged
merged 2 commits into from
Nov 11, 2022
Merged

chore: provide diagram-js/lib/ui #692

merged 2 commits into from
Nov 11, 2022

Conversation

nikku
Copy link
Member

@nikku nikku commented Nov 11, 2022

Exposes UI utilities through diagram-js/lib/ui as sketched here.

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 11, 2022
@nikku nikku requested a review from smbea November 11, 2022 09:28
@nikku
Copy link
Member Author

nikku commented Nov 11, 2022

I'm proposing to already incorporate this (outside of #687).

smbea
smbea approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@smbea smbea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@nikku nikku merged commit 2e530da into develop Nov 11, 2022
@nikku nikku deleted the diagram-js-ui branch November 11, 2022 10:15
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smbea smbea smbea approved these changes

Assignees

@nikku nikku

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikku @smbea