Correct various popup menu glitches #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ consolidate handling across header and body
|
Happy to split this one up over multiple PRs if that makes reviewing easier. |
|
The margin in the header entries is now significantly bigger. Was this intentional? Comparison: |
|
No, it is not. Will fix it. |
* Apply uniform margins in header and and body entries * Ensure entries do not cause margins unless needed * Align structure across header and body entries * Treat any `*icon` class as a marker (injecting an icon font symbol) * Consolidate icons sizes to always be full height
Allows users to inspect truncated items.
nikku
force-pushed
the
image-icons-margins
branch
from
23891c9 to
103b4c8
Compare
|
Accidentally added via 042ebe1 and now removed (again).
|
smbea
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The origin of this PR was an investigation to upgrade the bpmn-js-color-picker to use this library. That turned into adding an actual popup menu integration test and discovering + fixing a multitude of issues:
FIX: We don't account fortitleattribute in body entries; this is a regression (323bd88)FIX: We apply icon margins independent of whether or not the margin (between icon + X is needed). This requires us to workaround in downstream libraries (cf2c665)CHORE/FEAT: we don't addtitleconsistently (23891c9) to elements that truncate if too long (ce2470b)CHORE: misc theming improvementsIntegration test in action
While this PR applies basic structural HTML changes I regard them as fixes, rather than a new feature.
bpmn-js showcase
bpmn-js-color-picker extension (all custom styles dropped)