fix(context-pad): remove return statement #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
philippfromme
commented
May 7, 2024
philippfromme
commented
- return statement should have been removed with feat(context-pad): position absolute intead of relative to element #888
- account for possibility of target being array (target === [ target ])
- discovered when testing camunda-bpmn-js which includes bpmn-js-color-picker
barmac
reviewed
May 7, 2024
| @@ -1489,6 +1484,81 @@ describe('features/context-pad', function() { | |||
| expect(warnSpy).to.have.been.calledOnce; | |||
| expect(warnSpy.getCall(0).args[ 0 ]).to.be.instanceOf(Error); | |||
| expect(warnSpy.getCall(0).args[ 0 ].message).to.match(/is deprecated/); | |||
|
|
|||
| console.warn.restore(); | |||
There was a problem hiding this comment.
This won't be called if the test fails.
There was a problem hiding this comment.
Good catch, will adjust.
* return statement should have been removed with #888 * account for possibility of target being array (target === [ target ])
philippfromme
force-pushed
the
fix-context-pad
branch
from
1101e4b to
9cc91a4
Compare
|
@barmac I wrote a separate test for the warning with proper setup and teardown of the spy. |
nikku
approved these changes
May 7, 2024
barmac
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.