Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect Reverse #430

Merged
merged 3 commits into from
Nov 18, 2019
Merged

Connect Reverse #430

merged 3 commits into from
Nov 18, 2019

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Nov 4, 2019

Related to bpmn-io/diagram-js#427.

Closes #412.

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Nov 4, 2019
@philippfromme philippfromme force-pushed the 386-connect-reverse branch 3 times, most recently from 483b6ee to 4cb83a5 Compare November 5, 2019 08:34
@philippfromme philippfromme force-pushed the 386-connect-reverse branch 3 times, most recently from 0ae5640 to 3863d42 Compare November 6, 2019 18:27
@philippfromme philippfromme marked this pull request as ready for review November 6, 2019 18:28
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 6, 2019
@philippfromme
Copy link
Contributor Author

Failing due to the fact that we're not pulling in the corresponding diagram-js branch.

philippfromme and others added 3 commits November 18, 2019 16:18
* connecting reversely now possible
* removed behaviors that made connecting reversely possible
* fixed rules according to spec
* fixed and refactored DRD updating
* added test coverage for DRD updating

Closes #429
@nikku nikku force-pushed the 386-connect-reverse branch from c6fa274 to 85db049 Compare November 18, 2019 15:31
@nikku nikku merged commit 85db049 into develop Nov 18, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 18, 2019
@fake-join fake-join bot deleted the 386-connect-reverse branch November 18, 2019 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix DRD not working with diagram-js@4
2 participants