Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Shadow DOM and Document Fragments in closest method #7

Merged
merged 4 commits into from
Mar 11, 2020
Merged

Support Shadow DOM and Document Fragments in closest method #7

merged 4 commits into from
Mar 11, 2020

Conversation

oguzeroglu
Copy link
Contributor

Closes #5

@oguzeroglu oguzeroglu requested a review from nikku March 11, 2020 16:10
@nikku nikku merged commit 8328a13 into master Mar 11, 2020
@fake-join fake-join bot deleted the 5-shadow-dom-fix branch March 11, 2020 18:56
@nikku
Copy link
Member

nikku commented Mar 11, 2020

👏

@nikku
Copy link
Member

nikku commented Mar 11, 2020

Test running against all Firefox and Chrome in CI, too: aaa8ab4

Simplified shadow test element creation: 5f7c7dc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku Awaiting requested review from nikku

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

closest() breaks use of bpmn-js inside shadow DOM
2 participants
@oguzeroglu @nikku