Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

A Disgusting PR #3

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

A Disgusting PR #3

wants to merge 7 commits into from

Conversation

bradennapier
Copy link
Owner

@bradennapier bradennapier commented Jun 19, 2020

Wow, this is really ugly huh? Look at the ugly GitHub sweater of a change-set this PR wants to merge. Yucky.

@github-actions
Copy link
Contributor

Eslint Summary

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 8 8
Warnings 7 0

[failure] prettier/prettier

  • src/constants.ts Line 15 - Delete ⏎⏎⏎
  • src/constants.ts Line 21 - Delete ····
  • src/eslint.ts Line 56 - Insert ;
  • src/eslint.ts Line 63 - Insert ;
  • src/eslint.ts Line 86 - Insert ;
  • src/eslint.ts Line 143 - Replace annotation.path}#L${annotation.start_line}-L${annotation.end_line})·Line·${annotation.start_line with ⏎········annotation.path⏎······}#L${annotation.start_line}-L${annotation.end_line})·Line·${⏎········annotation.start_line⏎······
  • src/fs.ts Line 12 - Insert ,
  • src/utils.ts Line 26 - Replace ·).map((e)·=>· with ).map((e)·=>

[warning] @typescript-eslint/no-unused-vars

Disallow unused variables

  • src/api.ts Line 1 - 'github' is defined but never used.
  • src/api.ts Line 130 - 'client' is assigned a value but never used.
  • src/fs.ts Line 12 - 'unused' is defined but never used.

[warning] @typescript-eslint/no-explicit-any

Disallow usage of the any type

  • src/api.ts Line 52 - Unexpected any. Specify a different type.

    • [SUGGESTION] Use unknown instead, this will force you to explicitly, and safely assert the type is correct.
    • [SUGGESTION] Use never instead, this is useful when instantiating generic type parameters that you don't need to know the type of.
  • src/fs.ts Line 12 - Unexpected any. Specify a different type.

    • [SUGGESTION] Use unknown instead, this will force you to explicitly, and safely assert the type is correct.
    • [SUGGESTION] Use never instead, this is useful when instantiating generic type parameters that you don't need to know the type of.
  • src/types.ts Line 16 - Unexpected any. Specify a different type.

    • [SUGGESTION] Use unknown instead, this will force you to explicitly, and safely assert the type is correct.
    • [SUGGESTION] Use never instead, this is useful when instantiating generic type parameters that you don't need to know the type of.

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

  • src/fs.ts Line 12 - Argument 'unused' should be typed with a non-any type.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant