Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect translation when both day of month and day of week is set #272

Closed
1 task done
vivian-xu opened this issue Dec 27, 2022 · 2 comments
Closed
1 task done

Incorrect translation when both day of month and day of week is set #272

vivian-xu opened this issue Dec 27, 2022 · 2 comments

Comments

@vivian-xu
Copy link

vivian-xu commented Dec 27, 2022 •
edited
Loading

Cron Expression
1 1 3 * 3

Expected Output
"在上午 01:01, 限每月 3 号, 或星期三"

Actual Output
"在上午 01:01, 限每月 3 号, 并且为星期三"

Prerequisites

  • The cron expression being passed in is a valid expression. cRonstrue does not validate expressions and assumes the one you pass is already valid. See the FAQ for more details.
@bradymholt
Copy link
Owner

I would welcome a PR to fix this.

@mytharcher mytharcher mentioned this issue Jan 26, 2024
Merged
bradymholt pushed a commit that referenced this issue Feb 5, 2024
@mytharcher
fix: wrong word when DOM and DOW both present (#272) (#314)
c0244f4 
* fix: wrong word when DOM and DOW both present (#272)

* revert: rollback en in locale
@bradymholt
Copy link
Owner

Fixed by #314

@prernaadev01 prernaadev01 mentioned this issue May 27, 2024
Closed
@startree-cicd-2 startree-cicd-2 mentioned this issue Sep 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bradymholt @vivian-xu