Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

Commit

Permalink
removed the vscode config from contributing secion
Browse files Browse the repository at this point in the history
it is too much to explain installing the extensions, and adding the config, and disabling the beautify extension...
  • Loading branch information
bradzacher committed Nov 28, 2018
1 parent f7b43eb commit 22b1dba
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 11 deletions.
7 changes: 6 additions & 1 deletion .vscode/extensions.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
{
"recommendations": [
"esbenp.prettier-vscode",
"dbaeumer.vscode-eslint"
"dbaeumer.vscode-eslint",
"editorconfig.editorconfig"
],
"unwantedRecommendations": [
"hookyqr.beautify",
"dbaeumer.jshint"
]
}
10 changes: 0 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,16 +79,6 @@ Then configure the rules you want to use under the rules section.

## Contributing

If you're using vscode, we recommend you install both the Pretier and ESLint extensions, and turn on format on save.
```CJSON
{
// Format a file on save. A formatter must be available, the file must not be auto-saved, and editor must not be shutting down.
"[javascript]": {
"editor.formatOnSave": true
},
}
```

For a PR to be merged, all tests must pass, the must be no lint errors, and the code must be formatted.
- `yarn test`
- `yarn lint`
Expand Down

0 comments on commit 22b1dba

Please sign in to comment.