[FIX] Correct recommended warning rules (#263)

bradzacher · Dec 23, 2018 · 4d85404 · 4d85404
1 parent 7765028
commit 4d85404
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 6 deletions.
diff --git a/lib/configs/recommended.json b/lib/configs/recommended.json
@@ -13,7 +13,7 @@
         "camelcase": "off",
         "typescript/camelcase": "error",
         "typescript/class-name-casing": "error",
-        "typescript/explicit-function-return-type": "warning",
+        "typescript/explicit-function-return-type": "warn",
         "typescript/explicit-member-accessibility": "error",
         "indent": "off",
         "typescript/indent": "error",
@@ -23,7 +23,7 @@
         "no-array-constructor": "off",
         "typescript/no-array-constructor": "error",
         "typescript/no-empty-interface": "error",
-        "typescript/no-explicit-any": "warning",
+        "typescript/no-explicit-any": "warn",
         "typescript/no-inferrable-types": "error",
         "typescript/no-misused-new": "error",
         "typescript/no-namespace": "error",
@@ -32,7 +32,7 @@
         "typescript/no-parameter-properties": "error",
         "typescript/no-triple-slash-reference": "error",
         "no-unused-vars": "off",
-        "typescript/no-unused-vars": "warning",
+        "typescript/no-unused-vars": "warn",
         "typescript/no-use-before-define": "error",
         "typescript/no-var-requires": "error",
         "typescript/prefer-interface": "error",

diff --git a/lib/rules/explicit-function-return-type.js b/lib/rules/explicit-function-return-type.js
@@ -24,7 +24,7 @@ module.exports = {
                 "Require explicit return types on functions and class methods",
             category: "TypeScript",
             url: util.metaDocsUrl("explicit-function-return-type"),
-            recommended: "warning",
+            recommended: "warn",
         },
         schema: [
             {

diff --git a/lib/rules/no-explicit-any.js b/lib/rules/no-explicit-any.js
@@ -19,7 +19,7 @@ module.exports = {
             extraDescription: [util.tslintRule("no-any")],
             category: "TypeScript",
             url: util.metaDocsUrl("no-explicit-any"),
-            recommended: "warning",
+            recommended: "warn",
         },
         schema: [],
     },

diff --git a/lib/rules/no-unused-vars.js b/lib/rules/no-unused-vars.js
@@ -19,7 +19,7 @@ module.exports = Object.assign({}, baseRule, {
             extraDescription: [util.tslintRule("no-unused-variable")],
             category: "Variables",
             url: util.metaDocsUrl("no-unused-vars"),
-            recommended: "warning",
+            recommended: "warn",
         },
         schema: baseRule.meta.schema,
     },

diff --git a/tools/update-recommended.js b/tools/update-recommended.js
@@ -33,6 +33,13 @@ function generate() {
             const ruleName = `typescript/${key}`;
             const setting = allRules[key].meta.docs.recommended;
 
+            if (!["error", "warn"].includes(setting)) {
+                console.log(`ERR! Invalid level for rule ${key}: "${setting}"`);
+                // Don't want to throw an error since ^ explains what happened.
+                // eslint-disable-next-line no-process-exit
+                process.exit(1);
+            }
+
             console.log(ruleName.padEnd(MAX_RULE_NAME_LENGTH), "=", setting);
             config[ruleName] = setting;