Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Fix issue with declare module without body in prefer-namespace-keyword #195

Merged
merged 4 commits into from
Nov 29, 2018
Merged

Fix issue with declare module without body in prefer-namespace-keyword #195

merged 4 commits into from
Nov 29, 2018

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Nov 29, 2018 •
edited
Loading

This PR fixes issue #188

modules can have no body.

there was so much weird logic with tokens there, and we don't need it, it should just take id and previous token (module/namespace)....

weirdpattern
weirdpattern approved these changes Nov 29, 2018
View reviewed changes
Copy link
Collaborator

@weirdpattern weirdpattern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bradzacher bradzacher merged commit ea418ac into bradzacher:master Nov 29, 2018
@armano2 armano2 deleted the prefer-namespace-keyword branch November 29, 2018 17:04
@iwata
Copy link

iwata commented Dec 17, 2018

When publish this fixed version?

@bradzacher
Copy link
Owner

This is coming as part of v1.0.0
Which is almost finished.

@iwata
Copy link

iwata commented Dec 17, 2018

I see. Well then I can hardly wait for the release of v1.0.0!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@weirdpattern weirdpattern weirdpattern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@armano2 @iwata @bradzacher @weirdpattern