Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

cleanup no-use-before-define #202

Merged
merged 3 commits into from
Dec 6, 2018
Merged

cleanup no-use-before-define #202

merged 3 commits into from
Dec 6, 2018

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Dec 4, 2018 •
edited
Loading

This PR changes logic behind no-use-before-define to traverse all scopes

fixes: #141

@armano2 armano2 force-pushed the no-use-before-define branch from 3209ed2 to 78160b7 Compare December 4, 2018 19:17
@armano2 armano2 changed the title Add test case for ticket #141 refactor no-use-before-define Dec 4, 2018
@armano2
Copy link
Contributor Author

armano2 commented Dec 4, 2018 •
edited
Loading

There is one test case witch is invalid for typescript:

"use strict";
a();
{
  function a() {}
}

scopes (hoisting) is working a little different than in js

@armano2 armano2 changed the title refactor no-use-before-define cleanup no-use-before-define Dec 4, 2018
@bradzacher bradzacher merged commit 2c21510 into bradzacher:master Dec 6, 2018
@armano2 armano2 deleted the no-use-before-define branch December 6, 2018 18:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[no-use-before-define] false positive when exported var name corresponds to interface property name
2 participants
@armano2 @bradzacher