This repository was archived by the owner on Jan 19, 2019. It is now read-only.
[FEAT][BREAKING][1/2][member-delimiter-style] Better handling for single line #203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds better handling for single line delimiters, and better enforces the
requrieLast
option.Fixes #92
Single line delimiters
Previously single line delimiters were either checked or not. This meant that if you used
then the fixer would break your code by removing the delimiter from single line statements i.e.:
Breaking change:
ignoreSingleLine
singleLine: "none" | "semi" | "comma"
singleLine
works the same asdelimiter
, except for single line statements only.Stricter
requireLast
Previously
requireLast
did nothing when turned off, and enforced having a delimiter when turned on.I felt this was inconsistent with the goals of the linter; being a tool to provide consistent coding conventions.
This is the first of two changes to bring the option into line with eslint's
comma-dangle
. (The next change will replace the boolean with an enum; I didn't want to overload this PR).Breaking change:
requireLast: false
now enforces that there is no delimiter on the last member.