-
Notifications
You must be signed in to change notification settings - Fork 62
Conversation
I falled into small issue while doing this rule, autofix is not working as it should, and i'm still looking for workaround. eslint is not working correctly when fixer modifies begin and end of node, this prevents fixer of child nodes to be executed. // input.ts
type foo = Array<Array<Bar>>
// output.ts
type foo = Array<Bar>[] fixer is going to be applied only to first Array not to both ^ why? eslint applies fixer in sorted order base on range, when If token was already modified new changes are not going to be applied on it. possible solution:
|
@bradzacher what do you want me to do with fixer? i did some digging and looks like its working when you run it from cli but not in tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few nits but otherwise looks good.
blocking on parameterised messages.
Is there a reason you chose to use static messages instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome - great work!!
This is continuation of #117