Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

[FIX] [indent] add handling for TSTypeReference #273

Merged
merged 1 commit into from
Jan 4, 2019
Merged

[FIX] [indent] add handling for TSTypeReference #273

merged 1 commit into from
Jan 4, 2019

Conversation

bradzacher
Copy link
Owner

  • I’ve added tests for my changes

Fixes #271

@armano2
Copy link
Contributor

armano2 commented Jan 4, 2019 •
edited
Loading

@bradzacher there alot of more types present even if they are not supported/listed by parser.

some of them are not visitable:

  • TSRestType
  • TSParenthesizedType
  • TSOptionalType
  • TSIntersectionType
  • TSInferType
  • TSMappedType
  • TSRestType
  • TSThisType
  • TSTupleType

you can find example test scenarios here: https://github.com/eslint/typescript-eslint-parser/pull/590/files#diff-96c3fbe42e25c82d5705852f5d1e3fb2

but besides of that, commit looks ok

@bradzacher
Copy link
Owner Author

@armano2 I'll add support for those w/ tests in a separate PR

@bradzacher bradzacher merged commit 52fa7c5 into master Jan 4, 2019
@bradzacher bradzacher deleted the 271-indent-bug branch January 4, 2019 01:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armano2 armano2 armano2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bradzacher @armano2