Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReportProblem #176

Merged
merged 9 commits into from
Jan 2, 2021
Merged

Fix ReportProblem #176

merged 9 commits into from
Jan 2, 2021

Conversation

baruchiro
Copy link
Collaborator

@baruchiro baruchiro commented Dec 29, 2020

Now really fix #170

Fixing these:

  • Open in this repo (currently opened in the old one)
  • Typo in the title
  • Add OS and App version to the bug report

Example report:


Details

The bug details
Another line

Log

[2020-12-29 21:55:38.207] [info] The renderer process got the logger
[2020-12-29 21:55:51.970] [info] Open bug report url with title: seservr
[2020-12-29 21:57:31.526] [info] The renderer process got the logger
[2020-12-29 21:59:19.133] [info] The renderer process got the logger
[2020-12-29 22:01:11.334] [info] The renderer process got the logger
[2020-12-29 22:02:54.733] [info] The renderer process got the logger
[2020-12-29 22:11:38.177] [info] Welcome to budget-tracking log
[2020-12-29 22:11:38.212] [info] Version: 0.1.3-beta
[2020-12-29 22:11:56.238] [info] The renderer process got the logger

System Info

  • Source Version: unknown
  • OS: win32x64
  • OS Version: 10.0.20270

Copy link
Owner

@brafdlog brafdlog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logs you showed in the example are not our console logs.
Did you try running the flow and seeing if logs sent to console.log appear in the logs that are sent?

@baruchiro
Copy link
Collaborator Author

The logs you showed in the example are not our console logs.
Did you try running the flow and seeing if logs sent to console.log appear in the logs that are sent?

No, I'm planning to take all the logs things with #141

# Conflicts:
#	globals.js
#	src/types/global.d.ts
@baruchiro
Copy link
Collaborator Author

I don't know what is the problem with the Windows build. I will try again tomorrow.

electron-userland/electron-builder#1850
electron-userland/electron-builder-binaries#38

@baruchiro baruchiro merged commit c5a719c into master Jan 2, 2021
@baruchiro baruchiro deleted the baruchiro/issue170 branch January 2, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: ENOTDIR, not a directory
2 participants