Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add directory picker/#155 #253

Merged
merged 7 commits into from
Jun 13, 2021

Conversation

baaraak
Copy link
Contributor

@baaraak baaraak commented Jun 9, 2021

Fix #155

  • Add handlers file to register electron new event handlers (and initialize them in bacgkround.ts.
  • Add custom setup config to CSV (we should use it also in the JSON exporter

@baruchiro
Copy link
Collaborator

We still have 2 "bugs"

  1. The user can't enter filePath manually, so basically it's mean that he can't control the generated filename the default is 'transaction.csv' || 'transaction.json'.
    It's ok with you? Also, when the dialog is opened and the user selects a directory path, I get only the path and the file name 'transaction.csv' is removed.
    a. We can add the filename manually something like filePath = filePath + '/'transaction.csv''.
    b. We can do what I did in the start with the input + icon, then the user can select a path by clicking on the icon and using the dialog and editing it/change the filename.
    c. We can let the user choose 1 filename in a central place and all the exporter will use this file name

  2. The json/csv component, I wrote it in here: https://github.com/brafdlog/hiuvi/pull/253/files#diff-e7af9e850b9bf9f5a4b28ef8b5abb00958fde041449aff6497aaeb2e2c40c504R75

Originally posted by @baaraak in #155 (comment)

@baruchiro baruchiro self-requested a review June 9, 2021 14:59
Copy link
Collaborator

@baruchiro baruchiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. About the concern with the folder/file name, I think you just need to use the showSaveDialog instead of showOpenDialog. Note the showSaveDialog is not actually saving something. It is just the right dialog for selecting a path to a new file, instead of selecting a path of existing one.
  2. Not sure what you mean in the "json/csv component" "bug", maybe I answered you in my review...

Thanks! Good luck!!!!

@baruchiro
Copy link
Collaborator

@baaraak You can test the production version with the artifacts from here.

We will wait for @brafdlog if he wants to take a look, and I will merge it later.

@baruchiro baruchiro merged commit 96e8883 into brafdlog:master Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In CSV and JSON exporter settings use a ui file picker instead of text field to choose where to save the file
2 participants