Use config manager in Importers #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge #53 to make these validations pass |
|
The consistent naming convention in the repo is camelCase for directories and files so I would rename:
|
brafdlog
reviewed
Jun 12, 2020
| @@ -1,14 +1,7 @@ | |||
| /* eslint-disable max-len */ | |||
| import { createScraper, SCRAPERS } from 'israeli-bank-scrapers-core'; | |||
| import { createScraper } from 'israeli-bank-scrapers-core'; | |||
| import getChrome from './downloadChromium'; | |||
|
|
|||
There was a problem hiding this comment.
This change broke the import in Launch.spec.js and importers.vue.spec.js
brafdlog
reviewed
Jun 12, 2020
| @@ -76,34 +68,23 @@ export default { | |||
| data() { | |||
| return { | |||
| importing: false, | |||
| // TODO: show browser should be in config. Also maybe one for all accounts | |||
There was a problem hiding this comment.
Yes and yes. In general I think the common usecase is scrape all importers and then this type of configuration is global
brafdlog
force-pushed
the
useConfigManager
branch
from
35893e4 to
da1548d
Compare
brafdlog
reviewed
Jun 12, 2020
|
|
||
| // Remove when https://github.com/nklayman/vue-cli-plugin-electron-builder/issues/625 closed | ||
| const skip = process.env.GITHUB_ACTIONS && process.platform === 'win32'; | ||
| // const skip = process.env.GITHUB_ACTIONS && process.platform === 'win32'; | ||
| const skip = true; |
There was a problem hiding this comment.
The test got stuck both locally and in the ci. When debugging locally it seems it got stuck running testWithSpectron. Didn't even get to the tests themselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this change, I'm using Vuex (the official state manage for Vue) to hold and represent the
configobject fromconfigManager.Then, I'm using
vuex-persist. This is a little library to create a Vuex Plugin- a function that called every time the state is changed. Withvuex-persistI can define a handler for a specific module, so I created a handler for theconfigVuex module, to load this state fromconfigManagerand save it withconfigManagerevery time it changes.This leads us to the fact that the state will always be the same as the config. We have to remember this in both directions.