Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass size to content cb in MockRequestBuilder #87

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

jojoguru
Copy link

Since the callback function expects a $size argument from symfony 7.2 onwards

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.80%. Comparing base (47e0d3c) to head (24f2b82).
Report is 58 commits behind head on main.

Files with missing lines Patch % Lines
src/HttpClientMock/MockRequestBuilderFactory.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #87      +/-   ##
============================================
+ Coverage     52.04%   60.80%   +8.75%     
- Complexity      537      727     +190     
============================================
  Files            34       48      +14     
  Lines          1587     2074     +487     
============================================
+ Hits            826     1261     +435     
- Misses          761      813      +52     
Flag Coverage Δ
unittests 60.80% <0.00%> (+8.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jojoguru jojoguru force-pushed the fix/mockbuilder-httpclient-callback branch from 74839dc to 24f2b82 Compare January 28, 2025 16:18
@temp temp merged commit e52ff9e into brainbits:main Jan 29, 2025
4 of 5 checks passed
Copy link

🎉 This PR is included in version 6.1.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants