Rails 7.1 fix: use SelectRenderer for add_options and include FormOptionsHelper for … #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
requested changes
Dec 10, 2023
…currency_options_for_select
hishammalik
force-pushed
the
feature/rails-71
branch
from
4c7b911 to
e072788
Compare
oliverklee
requested changes
Dec 12, 2023
oliverklee
approved these changes
Dec 13, 2023
|
Sorry, this got merged to the wrong branch, which I accidentally overwrote. I'm going to manually re-apply your changes in a minute. Sorry for this. @hishammalik For the future, I'd like to ask you to only do PRs against a project's main branch (which usually is |
|
I've re-applied your changes now in #151. |
Closed
|
Hi @hishammalik, thank you so much again for contributing! ❤️ I've just released version 6.0.0 with your changes: https://github.com/braingourmets/currency_select/releases/tag/v6.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…currency_options_for_select