Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in RedisList slicing #331

Merged
merged 3 commits into from
Feb 2, 2021
Merged

Fix bug in RedisList slicing #331

merged 3 commits into from
Feb 2, 2021

Conversation

brainix
Copy link
Owner

@brainix brainix commented Feb 2, 2021

This was the previous buggy behavior:

>>> a = RedisList((1, 66.25, 1234.5))
>>> del a[:0]
>>> a
[]

This is the current correct behavior:

>>> a = RedisList((1, 66.25, 1234.5))
>>> del a[:0]
>>> a
[1, 66.25, 1234.5]

@brainix
Fix bug in RedisList slicing
4260bab 
This was the previous buggy behavior:

```python
>>> a = RedisList((1, 66.25, 1234.5))
>>> del a[:0]
>>> a
[]
```

This is the current correct behavior:

```python
>>> a = RedisList((1, 66.25, 1234.5))
>>> del a[:0]
>>> a
[1, 66.25, 1234.5]
```
@brainix
Improve unit test coverage
bf5802d
@brainix
Bump version number
1d0d0fa
@brainix
Copy link
Owner Author

brainix commented Feb 2, 2021

🐟

@brainix brainix merged commit fe1c23e into master Feb 2, 2021
@brainix brainix deleted the redislist-slice-bug-fix branch February 2, 2021 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brainix