Flesh out RedisDeque() code and tests #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it faster/easier/cheaper to run through the entire unit test suite while writing/debugging code locally.
- `RedisDeque.append()` - `RedisDeque.appendleft()` - `RedisDeque.pop()` - `RedisDeque.popleft()`
Before, I was naively `from tests.base import run_doctests`. This worked fine against source, but broke against the released package.
Ensure that neither self nor other changes during an equality comparison. If either changes, then (implicitly) raise a WatchError.
`RedisList.__eq__()` looks recursive, but it isn't, because a slice of a `RedisList` is a normal Python list (not a `RedisList`).
Explicitly avoid evaluating:
- `[]` as equal to `{}`, and
- `[0, 1]` as equal to `{0: 0, 1: 1}`
Also more cleanly separate mixin classes by behavior.
brainix
force-pushed
the
flesh-out-redis-deque
branch
2 times, most recently
from
d66fe64 to
5bd8ce6
Compare
brainix
force-pushed
the
flesh-out-redis-deque
branch
from
5bd8ce6 to
637bd39
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.