Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't let RedisLists equal tuples #397

Merged
merged 1 commit into from
May 10, 2021
Merged

Don't let RedisLists equal tuples #397

merged 1 commit into from
May 10, 2021

Conversation

brainix
Copy link
Owner

@brainix brainix commented May 10, 2021

This is how Python behaves:

>>> [1, 2, 3] == (1, 2, 3)
False

As of this PR, this is also how Pottery behaves:

>>> from pottery import RedisList
>>> RedisList((1, 2, 3)) == (1, 2, 3)
False

@brainix
Don't let RedisLists equal tuples
e7f4423 
This is how Python behaves:

```python
>>> [1, 2, 3] == (1, 2, 3)
False
```

As of this PR, this is also how Pottery behaves:

```python
>>> from pottery import RedisList
>>> RedisList((1, 2, 3)) == (1, 2, 3)
False
```
@brainix
Copy link
Owner Author

brainix commented May 10, 2021

🐟

@brainix brainix merged commit ac4bb82 into master May 10, 2021
@brainix brainix deleted the redislist-ne-tuple branch May 10, 2021 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brainix