Delegate method not invoked

[aodhol]

General information

• SDK/Library version: 4.10.0
• Environment: Sandbox
• iOS Version and Device: 11.2 iPhone 7 simulator / device.
• Integration type and version: Cocoapods 1.4.0 b2

Issue description

Delegate methods not getting invoked even though the SafariViewController is shown and dismissed via the big blue button.

`

 func paypalButtonTapped(_ sender: UIButton) {

    guard let braintreeClient = braintreeClient else {
        return
    }
    
    let payPalDriver = BTPayPalDriver(apiClient: braintreeClient)
    payPalDriver.viewControllerPresentingDelegate = self
    payPalDriver.appSwitchDelegate = self
    let payPalRequest = BTPayPalRequest(amount: "29.99")
    payPalDriver.requestOneTimePayment(payPalRequest) { (tokenizedPayPalAccount, error) -> Void in
         // do stuff...
    }
 }

`

[demerino]

@aodhol
See: #361 (comment)

On iOS11+ a SFAuthenticationSession is used for PayPal payments and does not require the delegate methods for presentation/dismissal.

Let us know if you have additional questions or feedback.

[aodhol]

@demerino But delegation or some means of knowing the lifecycle stage is surely needed to keep the UI in sync with what’s going on? I have a spinner on my button for example, how would I know to remove it if say the user cancels? There's also a delay between tapping the button and the SafariViewController appearing, leaving the user to wonder what's happening?

…

On Mon, 22 Jan 2018 at 02:17, David Merino ***@***.***> wrote: @aodhol <https://github.com/aodhol> See: #361 (comment) <#361 (comment)> On iOS11+ a SFAuthenticationSession <https://developer.apple.com/documentation/safariservices/sfauthenticationsession> is used for PayPal payments and does not require the delegate methods for presentation/dismissal. Let us know if you have additional questions or feedback. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#383 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAQw-kfG7lpkxCjeB9UxdfQcoNA_JU-aks5tM--5gaJpZM4RmCcz> .

[demerino]

@aodhol This makes sense. In this case, we would likely need to add a new generic lifecycle event that isn't coupled to app switching or presentation/dismissal. We'll look into this.

[aodhol]

@demerino shall I leave this open then?

[demerino]

Yes, we appreciate the feedback!

[demerino]

@aodhol 4.14.0 has added new BTAppSwitchDelegate methods which should work across all possible app switch scenarios.

Switch: http://braintree.github.io/braintree_ios/Protocols/BTAppSwitchDelegate.html#/c:objc(pl)BTAppSwitchDelegate(im)appContextWillSwitch:

Return: http://braintree.github.io/braintree_ios/Protocols/BTAppSwitchDelegate.html#/c:objc(pl)BTAppSwitchDelegate(im)appContextDidReturn:

[aodhol]

@demerino I've tested this on the BTPayPalDriver and can't get any of the delegate methods to trigger...

[ancafeurdean09]

@aodhol did you implement the BTAppSwitchDelegate? I tested myself and it works for me, both of the methods are getting called

[aodhol]

Yes, I did implement the delegate..

…

On 4 April 2018 at 14:49, ancafeurdean09 ***@***.***> wrote: @aodhol <https://github.com/aodhol> did you implement the BTAppSwitchDelegate? I tested myself and it works for me, both of the methods are getting called — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#383 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAQw-ulQv-mRa7Go1Zp51JvVykbR-2G1ks5tlM9wgaJpZM4RmCcz> .

[ancafeurdean09]

I followed the steps described in here: https://developers.braintreepayments.com/guides/paypal/client-side/ios/v4 when I first implemented this and now I just added those methods for testing purposes and I saw it's working fine, at least for me

[aodhol]

Yep, followed the exact same steps and none of the delegate methods get invoked..

…

On 4 April 2018 at 14:52, ancafeurdean09 ***@***.***> wrote: I followed the steps described in here: https://developers. braintreepayments.com/guides/paypal/client-side/ios/v4 when I first implemented this and now I just added those methods for testing purposes and I saw it's working fine, at least for me — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#383 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAQw-mUKDD4nB7WueygeJyjKTVS9f73vks5tlNAsgaJpZM4RmCcz> .

[demerino]

@ancafeurdean09 @aodhol Thanks for trying out the new methods.

I'm not sure why it isn't working for aodhol. Can you share the methods you implemented and the code snippet where you set the delegate?

[aodhol]

func paypalButtonTapped(_ sender: UIButton) {

        guard let braintreeClient = braintreeClient else {
            return
        }

        let payPalDriver = BTPayPalDriver(apiClient: braintreeClient)
        payPalDriver.viewControllerPresentingDelegate = self
        payPalDriver.appSwitchDelegate = self
        let payPalRequest = BTPayPalRequest(amount: "29.99")
        payPalDriver.requestOneTimePayment(payPalRequest) { (tokenizedPayPalAccount, error) -> Void in
        
            if let error = error {
               // .. handle error.
            }

            guard let tokenizedPayPalAccount = tokenizedPayPalAccount else {
                    return
            }

            // Post nonce to server ...

        }
    }

The delegate is in an extension on the view controller as follows:

extension ShoppingCartViewController: BTAppSwitchDelegate {
    func appSwitcherWillPerformAppSwitch(_ appSwitcher: Any) {
        print("appSwitcherWillPerformAppSwitch")
    }
  
    func appSwitcher(_ appSwitcher: Any, didPerformSwitchTo target: BTAppSwitchTarget) {
        print("didPerformSwitchTo")
    }
    
    func appSwitcherWillProcessPaymentInfo(_ appSwitcher: Any) {
         print("appSwitcherWillProcessPaymentInfo")
    }
}

[demerino]

I don't see the new optional delegate methods: appContextWillSwitch: and appContextDidReturn:.

    func appContextWillSwitch(_ appSwitcher: Any) {
        print("appContextWillSwitch")
    }
.....

[aodhol]

@demerino that was the problem :[ Thanks, and sorry!