Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Test Workflow #1089

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Update Test Workflow #1089

merged 1 commit into from
Aug 7, 2023

Conversation

jaxdesmarais
Copy link
Contributor

@jaxdesmarais jaxdesmarais commented Aug 4, 2023 •
edited
Loading

Summary of changes

  • CI started 💩 itself out of nowhere - did some research and found this issue on the GitHub actions runner
    • Seems like macos-13 is now defaulting to iOS 17... which is still in beta so buggy AF
    • We can hardcode our OS in xcodebuild as indicated in that thread here - hopefully in a later Xcode beta/GA this will be resolved and we can go back to letting CI do it's normal thing if we want

Checklist

  • [ ] Added a changelog entry

Authors

@jaxdesmarais jaxdesmarais changed the title [DRAFT] Update Workflow Update Test Workflow Aug 4, 2023
@jaxdesmarais jaxdesmarais marked this pull request as ready for review August 4, 2023 19:36
@jaxdesmarais jaxdesmarais requested a review from a team as a code owner August 4, 2023 19:36
hollabaq86
hollabaq86 approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@hollabaq86 hollabaq86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fun times 🙃 , ship it!

@jaxdesmarais jaxdesmarais merged commit e1f013b into main Aug 7, 2023
@jaxdesmarais jaxdesmarais deleted the update-test-workflow branch August 7, 2023 13:12
@jaxdesmarais jaxdesmarais mentioned this pull request Aug 7, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshropshire sshropshire sshropshire approved these changes

@hollabaq86 hollabaq86 hollabaq86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaxdesmarais @hollabaq86 @sshropshire