Add Shipping Callback URL to BTPayPalCheckoutRequest
#1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did we revert #1429 on the feature brach? |
|
Yes [DTMOBILES-1215], I accidentally recreated the feature branch |
jaxdesmarais
approved these changes
Oct 31, 2024
scannillo
reviewed
Oct 31, 2024
| @@ -98,20 +101,24 @@ import BraintreeCore | |||
| /// See https://developer.paypal.com/docs/api/reference/currency-codes/ for a list of supported currency codes. | |||
| /// - requestBillingAgreement: Optional: If set to `true`, this enables the Checkout with Vault flow, where the customer will be prompted to consent to a billing agreement | |||
| /// during checkout. Defaults to `false`. | |||
| /// - shippingCallbackURL: Optional: Server side shipping callback URL to be notified when a customer updates their shipping address or options. | |||
| /// A callback request will be sent to the merchant server at this URL. | |||
There was a problem hiding this comment.
Nit - does this line 105 appear under the shippingCallbackURL param docstring? Or since it's a newline it might appear in the general function description. (I'm admin-ed out of Xcode right now or else I'd check the preview)
There was a problem hiding this comment.
🦅 👁️ yeah, I wondered the same thing. The docstrings are a bit peculiar, i checked earlier, and this is how they look. What do you think?
scannillo
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
BTPayPalCheckoutRequestand pass it to support server-side shipping callbacks. Shipping callbacks should only be available for PayPal checkout flows.Checklist
Authors