Put groups into separate header entries #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/label sig-auth-acceptance |
stlaz
added
the
sig-auth-acceptance
stlaz
reviewed
Dec 3, 2024
kramaranya
force-pushed
the
group-header-separation
branch
2 times, most recently
from
7ca7546 to
5c50808
Compare
stlaz
reviewed
Dec 5, 2024
kramaranya
force-pushed
the
group-header-separation
branch
from
5c50808 to
ec99b4e
Compare
stlaz
reviewed
Dec 10, 2024
Signed-off-by: kramaranya <[email protected]>
Signed-off-by: kramaranya <[email protected]>
kramaranya
force-pushed
the
group-header-separation
branch
from
ec99b4e to
816c12d
Compare
|
The changes look good to me. I'm going to ask @ibihim to back me with a second pair of eyes 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add groups as separate header entries instead of concatenating them with a separator and update the corresponding unit test
Fixes: #330