Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plugin-permissions react-native-permissions versions #2730

Merged

Conversation

crherman7
Copy link
Contributor

@crherman7 crherman7 commented Aug 2, 2024

Describe your changes

In version 4.1.3 of react-native-permissions they changed the way they update their internal *.podspec file which our plugin does not accommodate for. To account for these changes - we will just execute the same ruby scripts that the documentation calls for.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Test Plan

  • yarn test
  • Run example app and verify camera permission works
ios

Simulator Screenshot - iPhone SE (3rd generation) - 2024-08-02 at 10 11 58

Checklist before requesting a review

  • A self-review of my code has been completed
  • Tests have been added / updated if required
  • Documentation has been updated to reflect these changes

@crherman7 crherman7 marked this pull request as draft August 2, 2024 14:15
@crherman7 crherman7 force-pushed the fix/plugin-permissions branch from ec9eaad to c920f96 Compare August 2, 2024 14:51
@crherman7 crherman7 marked this pull request as ready for review August 2, 2024 14:51
@NickBurkhartBB NickBurkhartBB merged commit 479c619 into brandingbrand:develop Aug 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants