Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set x-brave-api-key in stats ping header #10230

Closed
kkuehlz opened this issue Jun 11, 2020 · 4 comments · Fixed by brave/brave-core#5823
Closed

Set x-brave-api-key in stats ping header #10230

kkuehlz opened this issue Jun 11, 2020 · 4 comments · Fixed by brave/brave-core#5823
Labels
OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.12.x - Release #1

Comments

@kkuehlz
Copy link
Contributor

kkuehlz commented Jun 11, 2020 •
edited
Loading

#4488 Set x-brave-api-key in stats ping header

Add x-brave-api-key header with usage ping. Do this instead of passing it as a query param.

Test Plan

  1. Get a release of the browser that has not sent it's daily activity ping to laptop-updates
  2. Use charles/wireshark/etc and watch network requests
  3. See that api_key as a query parameter to https://laptop-updates.brave.com/1/usage

Miscellaneous Information:

Obsoletes test plan in #9911
@kkuehlz kkuehlz changed the title [Desktop] Set x-brave-api-key in stats ping header Jun 11, 2020
kkuehlz added a commit to brave/brave-core that referenced this issue Jun 11, 2020
@kkuehlz
Make stats ping api key a header
f2e8ee6 
This will give brave-core parity with iOS.

Resolves brave/brave-browser#10230
@kkuehlz kkuehlz mentioned this issue Jun 11, 2020
Merged
32 tasks
@kkuehlz kkuehlz added this to the 1.12.x - Nightly milestone Jun 15, 2020
@kkuehlz kkuehlz mentioned this issue Jun 29, 2020
Merged
4 tasks
bsclifton pushed a commit to brave/brave-core that referenced this issue Jun 29, 2020
@kkuehlz @bsclifton
Make stats ping api key a header
da07460 
This will give brave-core parity with iOS.

Resolves brave/brave-browser#10230
@kjozwiak kjozwiak mentioned this issue Jul 7, 2020
Closed
@LaurenWags
Copy link
Member

Marking as QA/Blocked - need a new build to test, 1.11.92 or newer.

This was referenced Jul 8, 2020
Closed
Closed
Closed
@LaurenWags
Copy link
Member

Removing QA/Blocked, https://github.com/brave/brave-browser/releases/tag/v1.11.92 is available

@LaurenWags LaurenWags mentioned this issue Jul 8, 2020
Closed
@LaurenWags
Copy link
Member

Re-adding QA/Blocked until #10610 is addressed.

@LaurenWags
Copy link
Member

LaurenWags commented Jul 17, 2020 •
edited by btlechowski
Loading

Verified passed with

Brave | 1.12.92 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified test plan from description

Verification passed on

Brave | 1.12.94 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.959)
  • Verified test plan from description
    image

Verification passed on

Brave 1.12.99 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Ubuntu 18.04 LTS
  • Verified test plan from description

@LaurenWags LaurenWags mentioned this issue Aug 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.12.x - Release #1
Development

Successfully merging a pull request may close this issue.

Make stats ping api key a header brave/brave-core
6 participants
@kjozwiak @rebron @LaurenWags @kkuehlz @btlechowski @GeetaSarvadnya