Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Privacy report modal position resizes when switching between Websites and Trackers #11320

Closed
srirambv opened this issue Aug 19, 2020 · 4 comments · Fixed by brave/brave-core#6537
Assignees
Labels
bug OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Privacy report modal jumps position when switching between Websites and Trackers

Steps to reproduce

  1. Clean install 1.14.44
  2. Enable privacy report via onboarding
  3. Do not visit any sites so that report has no entires
  4. Switch from websites to trackers, modal jumps from initial position even though there are no values

Actual result

trackerspopup

Expected result

Only resize the modal when there are entries

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? NA
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 10

Brave version

1.14.44

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

@srirambv srirambv added bug QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality labels Aug 19, 2020
@srirambv srirambv added this to the Android 1.13.x - Beta milestone Aug 19, 2020
@kjozwiak kjozwiak modified the milestones: Android 1.13.x - Beta, 1.13.x - Beta Aug 19, 2020
@srirambv
Copy link
Contributor Author

Looks bad on Tablet
image

@deeppandya
Copy link
Contributor

@srirambv I agree. I need to update the UI.

@deeppandya deeppandya self-assigned this Aug 19, 2020
@srirambv
Copy link
Contributor Author

Logged #11322 as a follow up for tablet

@srirambv
Copy link
Contributor Author

srirambv commented Sep 2, 2020

Verification passed on OnePlus 6T with Android 10 running 1.13.83 x64 build

  • Verified privacy report modal doesn't resize when switching between websites and trackers
    statsmodal

Tablet verification blocked on #11322
Verification passed on Samsung Tab A with Android 10 running 1.13.84 x64 build

  • Verified privacy report modal doesn't resize when switching between websites and trackers
    tabreport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants