Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Privacy report modal scale is pretty small on tablet #11322

Closed
srirambv opened this issue Aug 19, 2020 · 5 comments · Fixed by brave/brave-core#6563
Closed

[Android] Privacy report modal scale is pretty small on tablet #11322

srirambv opened this issue Aug 19, 2020 · 5 comments · Fixed by brave/brave-core#6563
Labels
android-tablet-specific design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. design A design change, especially one which needs input from the design team onboarding Front-end related to helping a new user learn about features within the browser. OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android Tab QA/Yes release-notes/exclude
Milestone
1.13.x - Release #2

Comments

@srirambv
Copy link
Contributor

srirambv commented Aug 19, 2020 •
edited by karenkliu
Loading

Description

Privacy report modal scale is pretty small on tablet

Steps to reproduce

  1. Clean install on nightly on a tablet
  2. Go through privacy report onboarding
  3. Once completed bring up a skinny privacy report modal

Actual result

skinnyprivacyreport

Expected result

Privacy report screen should scale on tablet.
Figma: https://www.figma.com/file/nSkt7Hz6sTU49Wtg23fBgX/Brave-Stats?node-id=201%3A3535

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? NA
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Tablet
  • Android version: 10

Brave version

1.14.44

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

Per @anthonypkeane - This issue is not a blocker for 1.13. We can update this in a later release.
@srirambv srirambv added design A design change, especially one which needs input from the design team design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. QA/Yes onboarding Front-end related to helping a new user learn about features within the browser. OS/Android Fixes related to Android browser functionality android-tablet-specific labels Aug 19, 2020
@srirambv srirambv added this to the 1.13.x - Beta milestone Aug 19, 2020
This was referenced Aug 19, 2020
Closed
Merged
@bsclifton bsclifton added the priority/P4 Planned work. We expect to get to it "soon". label Aug 27, 2020
@bsclifton bsclifton removed this from the 1.13.x - Release milestone Aug 27, 2020
@bsclifton
Copy link
Member

cc: @karenkliu for guidance on how to make this look better 😄

@anthonypkeane
Copy link

We can update this is a later release. While it doesn't look good on tablets it is functional and we can update in a later release. Not a blocker for 1.13

@deeppandya
Copy link
Contributor

@karenkliu @anthonypkeane @srirambv i have updated the UI. here i have attached a recording of the implementation.
https://slack-files.com/T04PX1BU8-F019U5K8M7X-9dd3c2b874

@deeppandya deeppandya added this to the Android 1.13.x - Release milestone Sep 1, 2020
@deeppandya deeppandya mentioned this issue Sep 1, 2020
Merged
32 tasks
@srirambv
Copy link
Contributor Author

srirambv commented Sep 2, 2020

Need to verify #11320 on tablet once this is fixed

@brave-builds brave-builds mentioned this issue Sep 2, 2020
Merged
4 tasks
@deeppandya deeppandya mentioned this issue Sep 2, 2020
Merged
4 tasks
@srirambv
Copy link
Contributor Author

srirambv commented Sep 3, 2020

Verification passed on Samsung Tab A with Android 10 running 1.13.84 x64 build

  • Verified privacy report modal is scaled to device viewport
    tabreport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android-tablet-specific design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. design A design change, especially one which needs input from the design team onboarding Front-end related to helping a new user learn about features within the browser. OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.13.x - Release #2
Development

Successfully merging a pull request may close this issue.

Update privacy reports UI for tablet brave/brave-core
4 participants
@bsclifton @deeppandya @anthonypkeane @srirambv