Ads on YouTube (pre-roll and banner overlays) not blocked when video is embedded

[Miyayes]

Description: Pre-roll video ads and banner overlay ads appear on YouTube videos that are embedded, such as those embedded or viewed on Reddit. Otherwise, ads seem to be properly blocked when viewing on YouTube itself.

Default shield settings.

System Info: Version 0.55.3 Chromium: 70.0.3538.12 (Official Build) dev (64-bit) — MacOS

Screenshots:

Note the Gatorade pre-roll video ad in the YouTube player.

Banner ads that overlay the video while its playing are also not blocked.

[bbondy]

Is this an issue with the muon based browser?

[Miyayes]

Is this an issue with the muon based browser?

@bbondy

I don't believe so. This is something that only happens in the Brave-core browser. For example, https://www.reddit.com/r/Documentaries/comments/9mxt2v/the_fake_abortion_clinics_of_america_2014_women/ has ads on Core (and you can see yellow spots on the timeline for ads), but none on Muon.

[srirambv]

Haven't seen any pre-roll ads on other site with embedded videos

[bbondy]

@Miyayes is this still an issue?

[Miyayes]

@Miyayes is this still an issue? @bbondy

Yes. Just tested it now on BETA, and very first embedded YouTube video on Reddit contained ads:

Version 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta (64-bit)

[FWDekker]

I experience the same, except that it happens on YouTube itself as well.

Brave 0.55.18 // Chromium 70.0.3538.67 (Official Build) (64-bit)

[bbondy]

We believe an adblock update fixed this, is anyone still getting ads?

[Miyayes]

We believe an adblock update fixed this, is anyone still getting ads?

@bbondy I'm still getting ads. Here's a screenshot of a YouTube video I just watched (embedded on Reddit). Note the banner ad. I also see a yellow notch in the video timeline when the video loads, indicating when an ad will appear:

Here is the link to the video on Reddit where I was able to reproduce: https://www.reddit.com/r/MMA/comments/9r3ju5/ufc_on_youtube_derrick_lewis_watches_derrick_lewis/

On MacOS, Version 0.55.20 Chromium: 70.0.3538.67 (Official Build) (64-bit).

[srirambv]

I don't see the ad itself on Beta(0.56.6) but I do see the close and info button of the ad banner. This is the embedded video from the same link

@Miyayes are you behind VPN ?

[bbondy]

Mainly I meant preroll video ads.
For the text overlay ads I think I know how to fix that with a cosmetic content script.

[srirambv]

I dont see preroll ads on the embedded video on reddit link

[LaurenWags]

Reproduced on macOS with an embedded video on neowin.net (https://www.neowin.net/news/unboxing-and-first-impressions-of-microsofts-surface-go)

Brave	0.56.7 Chromium: 70.0.3538.77 (Official Build) beta(64-bit)
Revision	0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS	Mac OS X

[Miyayes]

Reproduced on MacOS 0.56.12. Full out pre-roll video ad on embedded video:

[Miyayes]

This is reproducible for me, at least on Reddit, ~100% of the time. Here is a particularly egregious example where the pre-roll ad is 30 seconds long, but shields removes the "skip ad" button, leaving the user no choice but to submit to resign to the full ad:

[antonok-edm]

This was fixed with #10319.